Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch incomplete read and log which coil failed #162

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

elupus
Copy link
Collaborator

@elupus elupus commented Jun 10, 2024

This should allow easier fault tracing of issues with pumps crashing

See: home-assistant/core#118598

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.96%. Comparing base (7a4c599) to head (e6e8b15).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   57.84%   57.96%   +0.12%     
==========================================
  Files          14       14              
  Lines        1243     1261      +18     
==========================================
+ Hits          719      731      +12     
- Misses        524      530       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elupus
Copy link
Collaborator Author

elupus commented Jun 10, 2024

Ps. I noticed we do retries in the modbus connection. I wonder if that make sense there?

Copy link
Owner

@yozik04 yozik04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yozik04 yozik04 merged commit 8d5cd32 into yozik04:master Jun 11, 2024
8 checks passed
@yozik04
Copy link
Owner

yozik04 commented Jun 11, 2024

@elupus If you want to make a release please do it yourself. Bump app version in __init__.py and make a release with the same version. I am away from computer for couple weeks. 😄

@yozik04
Copy link
Owner

yozik04 commented Jun 11, 2024

Ps. I noticed we do retries in the modbus connection. I wonder if that make sense there?

TCP can still fail. I think it is fine.

@elupus elupus deleted the incomplete branch June 12, 2024 07:36
@elupus
Copy link
Collaborator Author

elupus commented Jun 12, 2024

Will do. Right, forgot modbus reconnects by itself in the background. I wonder if that will hide the exception i'm looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants