fix Fan speed current to show the fan mode instead of wrong % #165
Conversation
|
Not sure how to test with other nibe models. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 57.96% 57.96%
=======================================
Files 14 14
Lines 1261 1261
=======================================
Hits 731 731
Misses 530 530 ☔ View full report in Codecov by Sentry. |
| "unit": null, | ||
| "mappings": { | ||
| "0": "Normal", | ||
| "1": "Fan mode 1", |
There was a problem hiding this comment.
Does this match how things like uplink name them? Looks a bit weird with the parameter being called fan "speed", but the values being called fan "modes"
There was a problem hiding this comment.
Hey, no nibe uplink shows the % correctly
The configuration on my nibe is Mode 2 == 30%
Homeassistant shows 2%
I have a F730 not updated yet to the newest firmware with the new uplink feature. % where shown correctly with the old nibe uplink integration
I don't know if this behaves the same on other series.. just checked where the coil is defined and changed all of them...
After understanding that this is not the real % but the configured active one i would rather use AirFlow
But that has no unit and so displayed as state ;)
#163
|
I somehow missed this PR. |
|
Thank you! |
This PR fixes the fan speed current coils to show the fan mode instead of %
see #164