Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated parameter values for reversing-valve-hot-water s1155-s1255 #169

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

KptnHaddock
Copy link
Contributor

Value mapping for sensor reversing-valve-hot-water (qn10) 32197 updated from 0/1 to on/off for Nibe s1155 and s1255.

Under current github structure this is also applicable to Nibe s1256.

@yozik04
Copy link
Owner

yozik04 commented Jul 23, 2024

Did you use our script to build resulting json file?

@KptnHaddock
Copy link
Contributor Author

Admitting I have zero experience from previous work with Github, I would say yes.

Or perhaps better explained, I used Visual Studio Code under Windows. Made the suggested changes in the .csv file in my local environment and gave the command
py -m nibe.console_scripts.convert_csv
from the VS Code Terminal.
After having confirmed the expected updates in the corresponding .json file I made a Commit and PR.

Please let me know in case I missed and vital information, or nessesary step to the the correction right. Happy to learn and contribute if possible.

@yozik04
Copy link
Owner

yozik04 commented Jul 23, 2024

We really want CSV to be the source of everything for S series pumps. extensions.json is used to override values in CSV file while exporting to resulting json files.

@yozik04
Copy link
Owner

yozik04 commented Jul 23, 2024

What is in CSV for this line? Is it the same as we currently have?

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.96%. Comparing base (e6e8b15) to head (a3dff60).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   57.96%   57.96%           
=======================================
  Files          14       14           
  Lines        1261     1261           
=======================================
  Hits          731      731           
  Misses        530      530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KptnHaddock
Copy link
Contributor Author

Realize I gave you incorrect information.
I did not edit the CSV file, understanding its the origin extracted from the Nibe pumps.

I followed the instruction from the thread Nibe Integration is reporting numerical values as strings
#103975
saying "...You however cant modify the data file directly, you need to add you adjustments to the extensions file and run the python script to update the real json files...".

Sorry for confusion by mixing up the file types. My local environment comes from the Github source and my only contribution was to edit the extension file, running the pythong script and learn to contribute. Just let me know if any other information may be relevant in order to proceed.

@yozik04 yozik04 merged commit 2e80e70 into yozik04:master Jul 23, 2024
8 checks passed
@yozik04
Copy link
Owner

yozik04 commented Jul 23, 2024

Perfect. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants