Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion validation #184

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Conversion validation #184

merged 8 commits into from
Oct 18, 2024

Conversation

yozik04
Copy link
Owner

@yozik04 yozik04 commented Oct 18, 2024

I want to verify if json files are converted correctly from CSV files inside pull requests.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 76.25000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 69.88%. Comparing base (fcaac2f) to head (e214a7c).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
nibe/console_scripts/convert_csv.py 76.25% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   69.73%   69.88%   +0.14%     
==========================================
  Files          14       14              
  Lines        1325     1348      +23     
==========================================
+ Hits          924      942      +18     
- Misses        401      406       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner Author

@yozik04 yozik04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With conversion mappings from Series to a dictionary I need now to fix order of mappings in the json.

@yozik04
Copy link
Owner Author

yozik04 commented Oct 18, 2024

@elupus, you want to review it? I think it is fine as no JSON files were changed.

@yozik04 yozik04 merged commit 8d5c387 into master Oct 18, 2024
8 checks passed
Copy link
Collaborator

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reviewed in detail, but cursory it looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants