-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion validation #184
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 69.73% 69.88% +0.14%
==========================================
Files 14 14
Lines 1325 1348 +23
==========================================
+ Hits 924 942 +18
- Misses 401 406 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With conversion mappings from Series to a dictionary I need now to fix order of mappings in the json.
@elupus, you want to review it? I think it is fine as no JSON files were changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not reviewed in detail, but cursory it looks good
I want to verify if json files are converted correctly from CSV files inside pull requests.