Corrected some syntaxic and typing errors #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicalbertin
requested changes
May 6, 2019
deployments/testdata/test_client_service_generated_topology.yml
Outdated
Show resolved
Hide resolved
prov/terraform/openstack/testdata/OSInstanceWithServerGroup.yaml
Outdated
Show resolved
Hide resolved
prov/terraform/google/testdata/simpleComputeInstanceWithPersistentDisk.yaml
Outdated
Show resolved
Hide resolved
prov/terraform/google/testdata/simpleComputeInstanceWithPersistentDisk.yaml
Outdated
Show resolved
Hide resolved
prov/terraform/google/testdata/simpleComputeInstanceWithPersistentDisk.yaml
Outdated
Show resolved
Hide resolved
|
Hi Philippe, Thank you for your contribution! Most of the files you have modified are used for unit testing and indeed it may contain some issues on parts that are not really tested. We definitely lake of a TOSCA linter that could be integrated to our IDEs (VSCode and Goland)... |
|
Hi Loic, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
This PR proposes corrections of some lexical and typing errors found in TOSCA templates.
Description of the change
corrections of some lexical and typing errors found in TOSCA templates.
What I did
corrections of some lexical and typing errors found in TOSCA templates.
How I did it
Using the TOSCAware parser.
How to verify it
Description for the changelog
Applicable Issues