[extractor/twitch] Storyboards for Twitch VODs #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
requested changes
Jul 12, 2022
yt_dlp/extractor/twitch.py
Outdated
Comment on lines
442
to
443
| # sort from highest quality to lowest | ||
| spec.sort(key=lambda x: int_or_none(x.get('width')) or 0, reverse=True) |
There was a problem hiding this comment.
No need to sort. Core code should handle it
There was a problem hiding this comment.
Then sb1 will(might) be lower quality than sb0. I'd rather it be consistent with youtube (sb0 - highest quality, sb1 - lower, etc)
There was a problem hiding this comment.
Makes sense. Could u explain that in the comment coz the intention is not obvious
pukkandan
added
site-enhancement
Co-authored-by: pukkandan <[email protected]>
Co-authored-by: pukkandan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Added storyboard formats to twitch VoDs, similar to youtube storyboards.
Extractor does 1 more JSON request.
Also fixed a few tests.