Adding a service to generate bnf/diagrams

[premkumr]

Server

• Starts a service with --server
• make builds the code
• make server starts the server in debug mode with sample ebnf file
• eg: curl "localhost:1314/bnf?mode=diagram&rules=select"

Request params

• api : ysql/ycql (Default: ysql)
• version: preview/stable/v2.12 ... (Default: preview)
• mode : reference/grammar/diagram
• depth : number (optional param)
• rules : comma separated rule names (eg rules=select,select_start)
• local: comma separated rule names which will have local references (eg rules=select,select_start)

Tech spec

[jasonyb]

Before further review, could the changes be better documented in the PR (such as high-level approach), and could the README be updated with the new interface?

[jasonyb]

partial review

[premkumr]

Before further review, could the changes be better documented in the PR (such as high-level approach), and could the README be updated with the new interface?

Added detailed Tech Spec

[premkumr]

@jasonyb - Please let me know if you need ore changes !

[jasonyb]

why is ysql_grammar.ebnf added?

[premkumr]

why is ysql_grammar.ebnf added?

For testing. make server uses this file

[jasonyb]

Over half the comments are not addressed.

why is ysql_grammar.ebnf added?

For testing. make server uses this file

When you say testing, do you mean manual testing? What does make test do? If it actually runs tests, isn't it not server tests? Then you are still missing tests for the server. Not that you necessarily need it in the early stage.

[premkumr]

Over half the comments are not addressed.

@jasonyb - Not sure why this happened. They were all "hidden", I had to click to expand them. Only seeing them now. Will address them and then ping you.

[premkumr]

@jasonyb - let me know how this looks.