Skip to content

Commit

Permalink
[PLAT-15228] Update package installation command for YBA
Browse files Browse the repository at this point in the history
Summary:
We are seeing a dependency issue with react-bootstrap-table using an older version of react in its peer dependencies.
Given we don't have any plans to upgrade react-bootstrap-table soon and the fact that we want to keep our react version on 17, it was decided that we will use the `--legacy-peer-deps` option to install the packages anyways.

Test Plan:
Tested on a VM that replicated the dependency resolution issue seen in the build environment.
Observed a succesful `yb_release` run with no npm error.

Reviewers: rmadhavan, kkannan, lsangappa

Reviewed By: rmadhavan, lsangappa

Subscribers: yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D37923
  • Loading branch information
Jethro-M committed Sep 11, 2024
1 parent f5169ca commit eb61ef6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion managed/build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,7 @@ def runNpmInstall(implicit dir: File): Int =
println("npm version: " + Process("npm" :: "--version" :: Nil).lineStream_!.head)
println("npm config get: " + Process("npm" :: "config" :: "get" :: Nil).lineStream_!.head)
println("npm cache verify: " + Process("npm" :: "cache" :: "verify" :: Nil).lineStream_!.head)
Process("npm" :: "ci" :: Nil, dir).!
Process("npm" :: "ci" :: "--legacy-peer-deps" :: Nil, dir).!
}

// Execute `npm run build` command to build the production build of the UI code. Return 0 if success.
Expand Down

0 comments on commit eb61ef6

Please sign in to comment.