[YSQL] org.yb.pgsql.TestPgIndexSelectiveUpdate.testUpdateTableIndexWritesNoPushdown #18152
Open
1 task done
Assignees
Labels
area/ysql
Yugabyte SQL (YSQL)
kind/bug
This issue is a bug
priority/medium
Medium priority issue
status/awaiting-triage
Issue awaiting triage
Comments
shishir2001-yb
added
area/ysql
yugabyte-ci
added
kind/bug
|
The following test is failing as well org.yb.pgsql.TestPgIndexSelectiveUpdate.testUpdateTableIndexWrites |
karthik-ramanathan-3006
added a commit
that referenced
this issue
Sep 23, 2024
Summary: D36588 introduced an optimization to convert updates to included columns of indexes from requiring a DELETE + INSERT RPC to just a single UPDATE RPC. Furthermore, this optimization allows these index updates to be performed over a single flush to DocDB rather than requiring the previous two. The reduction in flushes has an impact on the DocDB metric: `intentsdb_rocksdb_write_self` for the index table. An update to an included column of an index now requires only 2 write batches to be written out to `intentsdb`: 1. The intent to update the column's value. Internal to DocDB/RocksDB, this includes the intents to delete the old value and insert the new value. 2. The intent to delete the intents mentioned in (1) once the operation has been committed to `regulardb`. Previously, this operation would have needed 3 writes batches: 1. The intent to delete the old value of the column. 2. The intent to insert the new value of the column. 3. The intent to delete the intents mentioned in (1) and (2) once the operation has been committed to `regulardb`. (1) and (2) were previously distinct because they happened over two separate flushes to DocDB which implies that they were part of two different write batches. Note - The cases where the metric was previously > 3, was due to the fact that more flushes (> 2) were needed to execute the query. These queries now just need 1 flush. This revision updates the `org.yb.pgsql.TestPgIndexSelectiveUpdate` with the new expectation for the metric `intentsdb_rocksdb_write_self`. Jira: DB-7192, DB-7625 Test Plan: ``` ./yb_build.sh --java-test 'org.yb.pgsql.TestPgIndexSelectiveUpdate' ``` Reviewers: tnayak Reviewed By: tnayak Subscribers: smishra, yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D38234
foucher
pushed a commit
that referenced
this issue
Sep 24, 2024
Summary: 5d3e83e [PLAT-15199] Change TP API URLs according to latest refactoring a50a730 [doc][yba] YBDB compatibility (#23984) 0c84dbe [#24029] Update the callhome diagnostics not to send gflags details. b53ed3a [PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule f0eab8f [PLAT-15278]: Fix DB Scoped XCluster replication restart 344bc76 Revert "[PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule" 3628ba7 [PLAT-14459] Swagger fix bb93ebe [#24021] YSQL: Add --TEST_check_catalog_version_overflow 9ab7806 [#23927] docdb: Add gflag for minimum thread stack size Excluded: 8c8adc0 [#18822] YSQL: Gate update optimizations behind preview flag 5e86515 [#23768] YSQL: Fix table rewrite DDL before slot creation 123d496 [PLAT-14682] Universe task should only unlock itself and make unlock aware of the lock config de9d4ad [doc][yba] CIS hardened OS support (#23789) e131b20 [#23998] DocDB: Update usearch and other header-only third-party dependencies 1665662 Automatic commit by thirdparty_tool: update usearch to commit 240fe9c298100f9e37a2d7377b1595be6ba1f412. 3adbdae Automatic commit by thirdparty_tool: update fp16 to commit 98b0a46bce017382a6351a19577ec43a715b6835. 9a819f7 Automatic commit by thirdparty_tool: update hnswlib to commit 2142dc6f4dd08e64ab727a7bbd93be7f732e80b0. 2dc58f4 Automatic commit by thirdparty_tool: update simsimd to tag v5.1.0. 9a03432 [doc][ybm] Azure private link host (#24086) 039c9a2 [#17378] YSQL: Testing for histogram_bounds in pg_stats 09f7a0f [#24085] DocDB: Refactor HNSW wrappers 555af7d [#24000] DocDB: Shutting down shared exchange could cause TServer to hang 5743a03 [PLAT-15317]Alert emails are not in the correct format. 8642555 [PLAT-15379][Fix PLAT-12510] Option to use UTC when dealing with cron exp. in backup schedule 253ab07 [PLAT-15400][PLAT-15401][PLAT-13051] - Connection pooling ui issues and other ui issues 57576ae [#16487] YSQL: Fix flakey TestPostgresPid test bc8ae45 Update ports for CIS hardened (#24098) 6fa33e6 [#18152, #18729] Docdb: Fix test TestPgIndexSelectiveUpdate cc6d2d1 [docs] added and updated cves (#24046) Excluded: ed153dc [#24055] YSQL: fix pg_hint_plan regression with executing prepared statement Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, jenkins-bot Differential Revision: https://phorge.dev.yugabyte.com/D38322
karthik-ramanathan-3006
added a commit
that referenced
this issue
Sep 30, 2024
…eUpdate Summary: D36588 introduced an optimization to convert updates to included columns of indexes from requiring a DELETE + INSERT RPC to just a single UPDATE RPC. Furthermore, this optimization allows these index updates to be performed over a single flush to DocDB rather than requiring the previous two. The reduction in flushes has an impact on the DocDB metric: `intentsdb_rocksdb_write_self` for the index table. An update to an included column of an index now requires only 2 write batches to be written out to `intentsdb`: 1. The intent to update the column's value. Internal to DocDB/RocksDB, this includes the intents to delete the old value and insert the new value. 2. The intent to delete the intents mentioned in (1) once the operation has been committed to `regulardb`. Previously, this operation would have needed 3 writes batches: 1. The intent to delete the old value of the column. 2. The intent to insert the new value of the column. 3. The intent to delete the intents mentioned in (1) and (2) once the operation has been committed to `regulardb`. (1) and (2) were previously distinct because they happened over two separate flushes to DocDB which implies that they were part of two different write batches. Note - The cases where the metric was previously > 3, was due to the fact that more flushes (> 2) were needed to execute the query. These queries now just need 1 flush. This revision updates the `org.yb.pgsql.TestPgIndexSelectiveUpdate` with the new expectation for the metric `intentsdb_rocksdb_write_self`. Jira: DB-7192, DB-7625 Original commit: 6fa33e6 / D38234 Test Plan: ``` ./yb_build.sh --java-test 'org.yb.pgsql.TestPgIndexSelectiveUpdate' ``` Reviewers: tnayak Reviewed By: tnayak Subscribers: yql, smishra Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D38507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-7192
Description
Unit Test
org.yb.pgsql.TestPgIndexSelectiveUpdate.testUpdateTableIndexWritesNoPushdownhas been flaky on master.Stability Report
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: