Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Log a NOTICE in Create Publication for all tables case for tables without pk #19291

Closed
1 task done
dr0pdb opened this issue Sep 26, 2023 · 0 comments
Closed
1 task done

[YSQL] Log a NOTICE in Create Publication for all tables case for tables without pk #19291

dr0pdb opened this issue Sep 26, 2023 · 0 comments
Assignees
@dr0pdb
Labels
area/cdcsdk CDC SDK area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@dr0pdb
Copy link
Contributor

dr0pdb commented Sep 26, 2023 •
edited by jira bot
Loading

Jira Link: DB-8102

Description

CDC does not support streaming tables without user defined primary key. So when a publication is created using the FOR ALL TABLES case, we skip them silently.

It might be better to log a NOTICE.

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@dr0pdb dr0pdb added kind/enhancement This is an enhancement of an existing feature area/ysql Yugabyte SQL (YSQL) priority/medium Medium priority issue labels Sep 26, 2023
@dr0pdb dr0pdb self-assigned this Sep 26, 2023
@dr0pdb dr0pdb mentioned this issue Sep 26, 2023
Open
@dr0pdb dr0pdb added the area/cdcsdk CDC SDK label Sep 26, 2023
dr0pdb added a commit that referenced this issue Nov 30, 2023
@dr0pdb
[#19291] YSQL: Add notice in Create Publication
6f00fba 
Summary:
CDC does not support streaming tables without user defined primary key. So when a publication is created using the `FOR ALL TABLES` case, we skip the unsupported tables silently.

This revision updates the behavior to a log a NOTICE for each of the unsupported tables. This is a follow-up from the original revision that enabled the Publication syntax: https://phorge.dev.yugabyte.com/D28721
Jira: DB-8102

Test Plan: `./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressPublication'`

Reviewers: dsrinivasan, skumar

Reviewed By: dsrinivasan

Subscribers: jason, yql

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D30470
@dr0pdb dr0pdb closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr0pdb dr0pdb

Labels
area/cdcsdk CDC SDK area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dr0pdb