[YSQL] Simplify the PatchStatus function #24040
Assignees
Labels
area/ysql
Yugabyte SQL (YSQL)
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
status/awaiting-triage
Issue awaiting triage
Comments
d-uspenskiy
added
kind/enhancement
d-uspenskiy
added a commit
that referenced
this issue
Sep 24, 2024
Summary: The is no reason to call the `PgSession::LoadTable` method in the `PatchStatus` function to get proper relation id. It is reasonable to sore relation id (`PgTableDesc::pg_table_id`) in the `relations` vector directly instead of `PgTableDesc::relfilenode_id`. **Note:** In context of this diff some cosmetic changes in the `BufferableOperations` class are performed: - rename of some methods to fit codding style - disallow non-const access to the `operations` and `relations` fields Jira: DB-12930 Test Plan: Jenkins Reviewers: fizaa, jhe, myang Reviewed By: myang Subscribers: ybase, yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D38221
timothy-e
pushed a commit
that referenced
this issue
Sep 24, 2024
Summary: 8916c1d [#21467,#21783, #23667] Docdb: Add sequences support for clone part 1 b4a0b45 [PLAT-14944] Enable db scoped replication if runtime config is enabled b062c44 Update link for crd file (#24083) d3f0da5 [PLAT-14898] Record reason for failing to enable node agent b135dfc update images (#24104) 846e35f [PLAT-14597] Fetch xCluster replication/DR configs with and without extra table info 1bc9e06 [#24091] xClusterDDLRepl: Pass automatic_ddl_mode to pollers afc424d [#23824] YSQL: Fix crash for when a RowComparisonExpression is used on a reordered primary key index 76a5c97 [#23943] YSQL: Fix Bitmap Scan GCC11 crash (follow-up) fd23b15 [#24040] YSQL: Simplify the PatchStatus function 47a4723 [PLAT-15441] Pin golang package version in build.sh to prevent incompatible versions to be installed 1edfa4c [PLAT-12224][PLAT-15238] Add metric for connection pooling Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Subscribers: telgersma Differential Revision: https://phorge.dev.yugabyte.com/D38365
d-uspenskiy
added a commit
that referenced
this issue
Oct 11, 2024
Summary: The is no reason to call the `PgSession::LoadTable` method in the `PatchStatus` function to get proper relation id. It is reasonable to sore relation id (`PgTableDesc::pg_table_id`) in the `relations` vector directly instead of `PgTableDesc::relfilenode_id`. **Note:** In context of this diff some cosmetic changes in the `BufferableOperations` class are performed: - rename of some methods to fit codding style - disallow non-const access to the `operations` and `relations` fields Jira: DB-12930 Original commit: fd23b15 / D38221 Test Plan: Jenkins Reviewers: fizaa, jhe, myang Reviewed By: myang Subscribers: yql, ybase Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D38927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-12930
Description
The is no reason to call the
PgSession::LoadTablemethod in thePatchStatusfunction to get proper relation id. It is reasonable to sore relation id in therelationsvector instead.Issue Type
kind/enhancement
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: