Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XCluster] DDL Replication - Skip CreateSequencesDataTable for AlterUniverseReplication #24164

Closed
hulien22 opened this issue Sep 26, 2024 · 0 comments
Closed

[XCluster] DDL Replication - Skip CreateSequencesDataTable for AlterUniverseReplication #24164

hulien22 opened this issue Sep 26, 2024 · 0 comments
Assignees
@hulien22
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue xCluster Label for xCluster related issues/improvements

Comments

@hulien22
Copy link
Contributor

hulien22 commented Sep 26, 2024 •
edited by jira bot
Loading

Jira Link: DB-13051
Currently we attempt to CreateSequencesDataTable for all SetupUniverseReplication requests, which also includes AlterUniverseReplication requests to add in new tables. This causes a lot of slow down as we only fail late in the creation flow due to the table already existing
@hulien22 hulien22 added kind/bug This issue is a bug area/docdb YugabyteDB core features xCluster Label for xCluster related issues/improvements labels Sep 26, 2024
@hulien22 hulien22 self-assigned this Sep 26, 2024
@yugabyte-ci yugabyte-ci added the priority/medium Medium priority issue label Sep 26, 2024
hulien22 added a commit that referenced this issue Sep 27, 2024
@hulien22
[#24164] xClusterDDLRepl: Skip CreateSequencesDataTable for AlterUniv…
c41a282 
…erseReplication

Summary:
Currently we attempt to CreateSequencesDataTable for all SetupUniverseReplication requests, which also includes AlterUniverseReplication requests to add in new tables. This causes unnecessary work as we have to go through a number of checks in CreateTable before realizing there's a duplicate table and returning.

Skipping this check for all alter replication requests as the sequences_data table is a global table, so would have been created during the original setup.
Jira: DB-13051

Test Plan: Jenkins

Reviewers: mlillibridge, hsunder, xCluster

Reviewed By: mlillibridge, hsunder

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D38484
timothy-e pushed a commit that referenced this issue Sep 30, 2024
@yugabyte-ci @timothy-e
[BACKPORT pg15-cherrypicks] all: Bulk port from master - 113
ca6c530 
Summary:
 a6d2802 [docs] Voyager left nav changes  (#24141)
 c629cfa [docs] added a missed alias (#24175)
 ef91421 [PLAT-15493] Failover fails post switchover in a replication setup
 2e25b7d [#23733] YSQL: Add conditional trigger tests for update optimization
 aca129f Fix lag metric name (#24178)
 c41a282 [#24164] xClusterDDLRepl: Skip CreateSequencesDataTable for AlterUniverseReplication
 fe84bfe [PLAT-13469] Health check to ensure systemd files have ExecPreStart
 81f0dfd [PLAT-15495] [UI] Add error column in node agent hidden page
 71ccee9 [PLAT-15358] Fix replication not existing logging message
 85e67fe [PLAT-15338] Improve formatting for very long universe names in DR participant cards
 8a71db3 [#24176] YSQL: Fix flaky test PgDdlAtomicitySanityTest.DdlRollbackMasterRestart
 b0d4d63 [#24145]: DocDB: Remove cdc specific yb_client from PgClientServiceImpl
 4bd9bd7 [PLAT-9803] Allow AWS universe to use any AWS instance type if runtime conf is set
 Excluded: 59b3636 [#24179] YSQL: INSERT ON CONFLICT batching
 Excluded: b9b57c6 [#24123] YSQL: Make a new ANN Access Method that redirects to the base table
 d8e4d30 [PLAT-15430]fix support bundle prometheus metrics query
 68d47f3 [PLAT-14030]Enable imdsv2 by default
 7fb93f2 [#24171] YSQL: Adapt of the PgCatalogPerfTest.ResponseCacheMemoryLimit unit test for pg15
 c18fd1c [#24190] CDCSDK: Enable tablet splitting on tables under CDCSDK stream by default
 8fade9b [PLAT-14966] [PLAT-14968] Edit KMS config reverts to default name in hashicorp vault
 347f14a [PLAT-15500][PLAT-15485]Fix read-replica edits for serviceEndpoint validations, move service-scope runtime config to Provider level
 fba6c68 [PLAT-15440] [PLAT][Metrics]IO write bytes are not calculated correctly for perprocess metrics
 247bed6 [PLAT-15534][YBA CLI]"yb-db-version list -o pretty" output is not a valid JSON
 99c5646 [PLAT-15437][PLAT-15445][YBA CLI] Changes to backup restore set of commands

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: tfoucher, fizaa, telgersma

Differential Revision: https://phorge.dev.yugabyte.com/D38550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hulien22 hulien22

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue xCluster Label for xCluster related issues/improvements
Projects
xCluster DDL Replication
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @hulien22