-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PITR: Handle YSQL colocated tables #8259
Labels
area/docdb
YugabyteDB core features
Comments
Taking point on this. cc @spolitov to avoid duplication. |
sanketkedia
added a commit
that referenced
this issue
Mar 22, 2022
Summary: This diff adds PITR support for colocation specified at a database level (not tablegroups). Essentially, we should now be able to restore dropped tables and indexes, undo various types of ALTER TABLE and drop existing tables and indexes (if they don't exist at the time to which we are restoring). This applies to tables and indexes that are created in a colocated database. Support for tablegroups isn't present in this diff. Test Plan: ybd --cxx-test yb-admin-snapshot-schedule-test --gtest_filter *YbAdminSnapshotScheduleTestWithYsqlParam* Reviewers: bogdan, sergei, nicolas Reviewed By: sergei Subscribers: ybase Differential Revision: https://phabricator.dev.yugabyte.com/D14960
sanketkedia
added a commit
that referenced
this issue
Mar 22, 2022
Summary: This diff adds PITR support for colocation specified at a database level (not tablegroups). Essentially, we should now be able to restore dropped tables and indexes, undo various types of ALTER TABLE and drop existing tables and indexes (if they don't exist at the time to which we are restoring). This applies to tables and indexes that are created in a colocated database. Support for tablegroups isn't present in this diff. Original commit: D14960 / 4443d06 Test Plan: Jenkins: rebase: 2.8 Jenkins: urgent Reviewers: bogdan, sergei Reviewed By: sergei Subscribers: ybase Differential Revision: https://phabricator.dev.yugabyte.com/D16121
sanketkedia
added a commit
that referenced
this issue
Apr 12, 2022
Summary: This diff adds PITR support for colocation specified at a database level (not tablegroups). Essentially, we should now be able to restore dropped tables and indexes, undo various types of ALTER TABLE and drop existing tables and indexes (if they don't exist at the time to which we are restoring). This applies to tables and indexes that are created in a colocated database. Support for tablegroups isn't present in this diff. Original commit: D14960 / 4443d06 Test Plan: Jenkins: rebase: 2.12 Jenkins: urgent Reviewers: bogdan, sergei Reviewed By: sergei Subscribers: ybase Differential Revision: https://phabricator.dev.yugabyte.com/D16214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In particular, in CatalogManager we have code to delete tables by calling
AsyncRemoveTableFromTablet
, which we'll need to properly be able to undo.The text was updated successfully, but these errors were encountered: