Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dom] Setting input value to null results in node.value === “null" in IE9 #1603

Closed
thekeyboardbum opened this issue Jan 31, 2014 · 1 comment
Assignees

Comments

@thekeyboardbum
Copy link

<input id="testnode" value=""/>
YUI().use('node',function(Y) {
    Y.one('#testnode').set('value',null); 
});

(12:07:23 PM) Tew: (it would probably not even occur to me to set empty input with null instead of an empty string)
(12:09:13 PM) apipkin: Tew: i agree. it’s a little strange to stringify the value from null to ”null” though
(12:15:29 PM) apipkin: Soooo, if that’s the case in IE9+ YUI should probably adjust for that within dom-attrs https://github.com/yui/yui3/blob/master/src/dom/js/dom-attrs.js#L128

ping @msweeney

okuryu added a commit to okuryu/yui3 that referenced this issue Feb 5, 2014
When set a node value to `null`, then a node value returns `"null"` as string
on the legacy IE (IE <= 9). A node value returns an empty string on the modern
browsers (Chrome, Firefox, IE >= 10). This change is to normalize the results
of setting a node value to `null` on any browsers. Fix yui#1603.
@okuryu okuryu self-assigned this Feb 6, 2014
@okuryu okuryu added this to the Sprint 12 Code Freeze milestone Feb 6, 2014
@okuryu
Copy link
Member

okuryu commented Feb 12, 2014

#1611 has been merged.

@okuryu okuryu closed this as completed Feb 12, 2014
@okuryu okuryu removed the 3 - Review label Feb 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants