Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[History] : Remove history-hash-ie from roll up. #1613

Merged
merged 1 commit into from
Feb 11, 2014

Conversation

ezequiel
Copy link
Contributor

@ezequiel ezequiel commented Feb 6, 2014

This caused history-hash-ie to load on non-IE browsers. It's okay to remove this, as history-hash-ie will conditionally load when history-hash is requested.

Here's a test of this fix in action: http://jsbin.com/xeci/4

@ericf @rgrove @clarle

@ericf
Copy link
Member

ericf commented Feb 6, 2014

Looks like it's working. I assume you see history-hash-ie still being loaded on old IE?

@ezequiel
Copy link
Contributor Author

ezequiel commented Feb 6, 2014

Yeah. This is what I see in IE 7:

ie7

@clarle
Copy link
Collaborator

clarle commented Feb 6, 2014

Looks great, go for it. :shipit:

@ericf
Copy link
Member

ericf commented Feb 6, 2014

Good deal. And what @clarle said!

@caridy
Copy link
Member

caridy commented Feb 6, 2014

we should double check if there is any other *-ie specific module in a requires list?

@rgrove
Copy link
Contributor

rgrove commented Feb 6, 2014

I think this was a remnant from the days when rollups were actually static rollups and not just dynamic aliases. Should be safe to remove.

@ezequiel ezequiel merged commit b95915d into yui:dev-master Feb 11, 2014
@ezequiel ezequiel deleted the app-history-fix branch February 27, 2014 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants