Package library with jarjar to prevent conflict of custom rhino impl #289
Conversation
- Update Java requirement : now build with and for 1.6 - Include jarjar library (in its version 1.4.1 for compat with Java 8) - Change build process to create the jar with a completely rewritten package of Rhino. This will ensure that YuiCompressor can be bundle with any more up to date version of Rhino without ever conflicting
|
Could it be that this build fails because of a change on Travis CI (and not due to the PR content itself) ?? |
|
Nice work. I really wish someone would just fork this project and take it over. This project seems dead and they are not really fixing PR's or doing any new releases. |
|
Thanks @melloware. Yes quite unfortunate that this project no longer has any maintainer :( |
build.xml
Outdated
| @@ -33,32 +33,38 @@ | |||
| deprecation="off" | |||
| debug="on" | |||
| includeantruntime="false" | |||
| target="1.5" | |||
| source="1.5"> | |||
| target="1.6" | |||
There was a problem hiding this comment.
there's a tab on this line that should be converted to spaces
build.xml
Outdated
| <target name="build.jar" depends="build.classes"> | ||
| <mkdir dir="${build.dir}/jar"/> | ||
| <target name="build.jar" depends="build.classes"> | ||
| <mkdir dir="${build.dir}/jar"/> |
There was a problem hiding this comment.
you added a tab here. please only use spaces
build.xml
Outdated
| <classpath> | ||
| <pathelement location="${lib.dir}/jargs-1.0.jar"/> | ||
| <pathelement location="${lib.dir}/rhino-1.7R2.jar"/> | ||
| </classpath> | ||
| </javac> | ||
| </target> | ||
|
|
||
| <target name="build.jar" depends="build.classes"> | ||
| <mkdir dir="${build.dir}/jar"/> | ||
| <target name="build.jar" depends="build.classes"> |
build.xml
Outdated
|
|
||
| <taskdef name="jarjar" classname="com.tonicsystems.jarjar.JarJarTask" | ||
| classpath="${lib.dir}/jarjar-1.4.1.jar"/> | ||
| <jarjar jarfile="${build.dir}/${jar.name}" duplicate="fail"> |
|
This change was also proposed in #179 |
|
@benmccann thanks for your feedbacks. PR updated. The build is still not passing, but I don't get why it would be related to my commit. I suspect it is related to the recent change on Travis CI. But I am really not familiar with TravisCI and its build process... If you have any idea on this matter. It would be helpful. |
package of Rhino. This will ensure that YuiCompressor can be
bundle with any more up to date version of Rhino without ever
conflicting
This PR should fix the following issues :