Issue81 fix hsl compression #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this is not the most optimized output, it is correct output. This should be the minimum target, and is the problem described in the related issue yui#81.
|
The travis CI stuff is broken. It fails attempting to setup java 6, and seems to indicate that it requires java 9 at a minimum. |
|
I have backported this fix into our Maven Plugin: https://github.com/primefaces-extensions/resources-optimizer-maven-plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken handling of CSS colors specified as hsl() and rgb().
For each of those functions some arguments require the use of
%, even if the value is zero. Do not strip percent signs from arguments in these cases.