Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parser issue with input ending with non-space characters #28

Closed
wants to merge 2 commits into from
Closed

Conversation

d5
Copy link

@d5 d5 commented Nov 14, 2019

Discovered that the input string that ends with non-whitespace characters caused an incorrect parsing. For example, the following input (fenced code block with no newlines at the end)

```
abc
```

is parsed as a fenced code block followed by another paragraph with text value of "`".

I don't know if the spec requires all input string to end with 1+ newline characters or not, but, appending a whitespace character at the end fixed most of my own use cases. Feel free to close/ignore if you have a better fix 😄 .

Thanks!

@yuin
Copy link
Owner

yuin commented Nov 16, 2019

Thanks for reporting this, but this PR contains some problems. So I will try to fix the issue by myself.

@yuin yuin closed this Nov 16, 2019
yuin pushed a commit that referenced this pull request Nov 16, 2019
yuin added a commit that referenced this pull request Nov 16, 2019
yuin added a commit that referenced this pull request Nov 16, 2019
yuin added a commit that referenced this pull request Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants