v0.34.0 を同期 #4
Merged
v0.34.0 を同期 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Placeholder documentation] Show deprecated message within the warning box
[Documentation] Fix warning box/text in docs
[FlowLayout Documentation] Update flowlayout.md
If there is a nested NavGraph under the current bottomSheet destination and you do a back press, instead of the bottomSheet which is the topmost destination being popped, the nested NavHost underneath will be popped instead. This is caused by bottomSheet not properly intercepting back presses. This change added a BackHandler to ensure that bottomsheets correctly respect the system back hierarchy for back events. Fixes: google#1726
[Navigation Material] Ensure Navigation Material properly handles back for nested nav
[ThemeAdapter-Material3] Fix warning in docs
Upgrade to Compose 1.6 stable
ykws
reviewed
Apr 17, 2024
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| ## Notice: About this fork | |||
| 本レポジトリは fork 元である [google/accompanist](https://github.com/google/accompanist) において非推奨となる API を保持することを目的としています。 | |||
| 動作、問題の解決やメンテナンスなどは一切保証しません。 | |||
| バージョンは [v0.33.2-alpha](https://github.com/google/accompanist/releases/tag/v0.33.2-alpha) を用いています。 | |||
| バージョンは [v0.34.0](https://github.com/google/accompanist/releases/tag/v0.33.2-alpha) を用いています。 | |||
There was a problem hiding this comment.
リンク先も修正しておきたいです
Suggested change
| バージョンは [v0.34.0](https://github.com/google/accompanist/releases/tag/v0.33.2-alpha) を用いています。 | |
| バージョンは [v0.34.0](https://github.com/google/accompanist/releases/tag/v0.34.0) を用いています。 |
There was a problem hiding this comment.
漏れてました 🙏
b660bef で対応しました！
| @@ -1,18 +1,18 @@ | |||
| [versions] | |||
|
|
|||
| compose = "1.6.0-alpha06" | |||
| composeCompiler = "1.5.3" | |||
| compose = "1.6.0" | |||
|
#3 のマージでのコンフリクトを解決 |
ue-moo
approved these changes
Apr 23, 2024
| @@ -185,6 +186,10 @@ public class BottomSheetNavigator( | |||
| LaunchedEffect(retainedEntry) { | |||
| sheetState.show() | |||
| } | |||
|
|
|||
| BackHandler { | |||
| state.popWithTransition(popUpTo = retainedEntry!!, saveState = false) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compose の安定版を用いている v0.34.0 の内容を同期する