Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache allRules #57

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Cache allRules #57

merged 4 commits into from
Nov 2, 2023

Conversation

morikann
Copy link
Contributor

@morikann morikann commented Nov 2, 2023 •
edited
Loading

Issue

Overview (Required)

  • Cache allRules to avoid extra data fetching.
  • fix typo of notRecommendedAllRules.

@morikann morikann changed the title Feature/#47 Cache allRules Nov 2, 2023
@morikann morikann marked this pull request as ready for review November 2, 2023 05:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Ready for review 🚀

blendthink
blendthink approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morikann
I have made one comment, but it's LGTM! Thank you for your work!

tools/update_lint_rules/lib/src/services/lint_rule_service.dart Show resolved Hide resolved
blendthink
blendthink approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work! LGTM!

tools/update_lint_rules/lib/src/services/lint_rule_service.dart Show resolved Hide resolved
@morikann morikann merged commit 643be02 into main Nov 2, 2023
@morikann morikann deleted the feature/#47 branch November 2, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blendthink blendthink blendthink approved these changes

@K9i-0 K9i-0 Awaiting requested review from K9i-0

@trm11tkr trm11tkr Awaiting requested review from trm11tkr

@Yamasaki-pan961 Yamasaki-pan961 Awaiting requested review from Yamasaki-pan961

@YumNumm YumNumm Awaiting requested review from YumNumm

Assignees

@morikann morikann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache allRules
2 participants
@morikann @blendthink