Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/updates and improvements #1

Merged
merged 3 commits into from
Dec 5, 2021

Conversation

Steppico
Copy link
Contributor

Hi there,

cool idea of having an API for Dune! I'm loving it. When I tried to use the API, I noticed how the documentation didn't match the actual code for retrieving specific quotes, so I forked this project and worked a little bit on it.

In this PR, I am:

  • updating the documentation;
  • removing an unnecessary piece of code in server;
  • updating the return value in the getArticle function when id is smaller than 0 to return the first item of the list.

I hope you can review this and eventually merge it, if you consider it appropriate.
I'm available to continue contributing if you have ideas, or need help for expanding this.

@ywalia01
Copy link
Owner

Hey @Steppico ,

Thanks for the contribution! I have reviewed the PR and it seems okay to me, will merge it soon.
It's been a while since I've touched this project as I've been busy with exams and stuff, but I do have a lot of ideas planned for this project that we could implement such as:

I'm open to other ideas as well, and would love to discuss about em. Thanks for reviving this project :)
Also, if you're okay with it, we could take this dicussion to discord. Do let me know.

Cheers!

@Steppico
Copy link
Contributor Author

Steppico commented Dec 5, 2021

Hey @ywalia01 ,
sure thing we can take it to Discord, I should be more active then ✌️
I'm sending you a DM on Twitter with my username.

@ywalia01 ywalia01 merged commit ae4ff1d into ywalia01:main Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants