Introduce blockbeat - implement Consumer on resolvers
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
a203f49
to
055e150
Compare
yyforyongyu
force-pushed
the
yy-block-beat
branch
2 times, most recently
from
c79af29
to
5431724
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
055e150
to
df60558
Compare
yyforyongyu
force-pushed
the
yy-block-beat
branch
from
5431724
to
7e8fe73
Compare
This commit moves the `HarnessMiner` into a new package to avoid confusion about incoming changes.
This commit adds more assertion to `MineBlocks` so the caller won't misuse it.
in harness Prepare to make `HarnessTest.Miner` a private instance to sync height.
`MineBlocksAndAssertNumTxes`
So the block data can be used by subsystems without calling `GetBlock`.
Also updated the loggings. This new state will be used in the following commit.
This commit adds a new method `handleInitialBroadcast` to handle the initial broadcast. Previously we'd broadcast immediately inside `Broadcast`, which soon will not work giving the blockbeat being used in the following commit.
Previously in `markInputFailed`, we'd remove all inputs under the same group via `removeExclusiveGroup`. This is wrong as when the current sweep fails for this input, it shouldn't affect other inputs.
Also updated `handlePendingSweepsReq` to skip immature inputs so the returned results are the same as those in pre-0.18.0.
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
df60558
to
0712afa
Compare
This commit inits the package `chainio` and defines the interface `Consumer`, which must be implemented by other subsystems if it requires block epoch subscription.
In this commit, a minimal version of `Blockbeat` is added to synchronize block heights, which will be used in `ChainArb`, `Sweeper`, and `TxPublisher` so blocks are processed sequentially among them.
This commit implements `Consumer` on `TxPublisher`, `UtxoSweeper`, `ChainArbitrator` and `ChannelArbitrator`. In addition, a `BlockConsumer` is added to save code duplication.
This commit removes the independent block subscriptions in `UtxoSweeper` and `TxPublisher`. These subsystems now listen to the `BlockbeatChan` for new blocks.
The sweeper can handle the waiting so there's no need to wait for blocks inside the resolvers. By offering the inputs prior to their mature heights also guarantees the inputs with the same deadline are aggregated.
This commit removes the block subscriptions used in `ChainArbitrator` and `ChannelArbitrator`, replaced them with the blockbeat managed by `BlockbeatDispatcher`.
This `immediate` flag was added as a hack so during a restart, the pending resolvers would offer the inputs to the sweeper and ask it to sweep them immediately. This is no longer need due to `blockbeat`, as now during restart, a block is always sent to all subsystems via the flow `ChainArb` -> `ChannelArb` -> resolvers -> sweeper. Thus, when there are pending inputs offered, they will be processed by the sweeper immediately.
This commit implements the `chainio.Consumer` interface so resolvers can start listening to blockbeat.
yyforyongyu
force-pushed
the
yy-block-beat
branch
from
7e8fe73
to
711a449
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
2 times, most recently
from
8242ffd
to
bc13d54
Compare
yyforyongyu
changed the title
blockbeatblockbeat - implement Consumer on resolvers
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
4 times, most recently
from
3b91244
to
fb67045
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
2 times, most recently
from
799f05b
to
a0393a0
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
4 times, most recently
from
8b95551
to
9ec032a
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
9ec032a
to
436aece
Compare
yyforyongyu
force-pushed
the
yy-prepare-blockbeat
branch
from
436aece
to
f6c5de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach where all the resolvers implement the
Consumerinterface, starting at this commit 9cdbd5b.