Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Also use words from codespell settings #12

Closed
jakobhviid opened this issue Feb 21, 2019 · 9 comments
Closed

Feature Request: Also use words from codespell settings #12

jakobhviid opened this issue Feb 21, 2019 · 9 comments

Comments

@jakobhviid
Copy link

Hi.

After you kindly implemented the option to add custom words to, it became obvious to me that most, but not all, words are duplicated in the Code Spell Extension settings that looks like this:

{
  "cSpell.userWords": [
    "Bosswave",
    "Fierro",
    "Fuseki",
    "GDPR",
    "Hviid",
    "Nellemann",
    "OccuRE",
    "SMAP",
    "XBOS",,
    "blockchain",
    "chktex",
    "failover",
    "microservice",
    "microservices",
    "reconfiguring",
    "subfield",
    "subfields"
  ]
}

For this reason, i propose adding a setting for reading the cspell.userWords setting too for auto completion purposes. So, when a user adds a word to code spell, it can automatically be added to the autocomplete suggestion list.

It is just a string array, so i imagine it is trivial to add to the functionality you already created when reading from the settings list. I imagine a "dictCompletion.useCodeSpellUserWords": true as an option.

This would cleanup the settings files immensely as words are not duplicated between the setting lists, and would allow the user to do less maintenance of the wordlist manually, as relevant words gets added automatically over time.

Let me know what you think.

@yzhang-gh
Copy link
Owner

This is trivial. The only problem is my laptop was broken yesterday...

@jakobhviid
Copy link
Author

I am sad to hear of your problems with your laptop. I hope you get it resolved soon.

The feature is fortunately not time sensitive, and less essential than the other feature you implemented.

@yzhang-gh
Copy link
Owner

Please see the dev build.

@jakobhviid
Copy link
Author

I can confirm it works as expected! Thank you!

@jakobhviid
Copy link
Author

Hello. Do you have an ETA of when this is moving to the VS Code marketplace?

@yzhang-gh
Copy link
Owner

Probably this weekend

@jakobhviid
Copy link
Author

From what i can see, this still has not gone into the official extension. Any chance you have time to look at it soon?

@yzhang-gh
Copy link
Owner

Oops, thanks for the reminder. It should get updated now.

@jakobhviid
Copy link
Author

You are welcome. And thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants