Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong getCoord further #1

Merged
merged 1 commit into from
Nov 7, 2021
Merged

fix wrong getCoord further #1

merged 1 commit into from
Nov 7, 2021

Conversation

kaorahi
Copy link

@kaorahi kaorahi commented Nov 6, 2021 •
edited
Loading

(for featurecat#827)

Lizzie and KataGo use different orders in serializations of 2D arrays. So we need different getCoord for Lizzie and KataGo.

Your code seems to have unwilling side effects in Lizzie.

  • Original code: y = 0, 1, ..., boardHeight - 1.
  • Your code: y = 0, 1, ..., boardWidth - 1.

The former seems right for Lizzie.

@kaorahi kaorahi mentioned this pull request Nov 6, 2021
Open
@yzyray yzyray merged commit 8dafe7d into yzyray:fixgetcoords Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaorahi @yzyray