Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences button not visible #50

Closed
nightsky30 opened this issue May 10, 2019 · 9 comments
Closed

Preferences button not visible #50

nightsky30 opened this issue May 10, 2019 · 9 comments
Labels

Comments

@nightsky30
Copy link

nightsky30 commented May 10, 2019

Maybe it is me and I'm just really missing it, but I don't see a preferences button anywhere. My layout looks like the following (without the downloaded images):

prefs_gone

In #43 (comment) it is mentioned there is a button in the lower left, but I don't see one. I'd really like to be able to download the image files for my devices, but cannot access the setting in preferences.

For reference I'm running Xubuntu 19.04 (XFCE), OpenRazer 2.5.0, and RazerGenie 0.8.1

@nightsky30
Copy link
Author

nightsky30 commented May 10, 2019

Update:

The button is actually there, but invisible!!! I noticed the Daemon Version label was slightly skewed to the right compared to the reference image used above. I decided to click in that blank area, and a box popped up!

Screenshot_2019-05-09_21-40-55

Screenshot_2019-05-09_21-40-10

@z3ntu
Copy link
Owner

z3ntu commented May 22, 2019

I'm using the configure icon from the icon theme, which apparently isn't available on your system (I've also seen this problem on Windows where there are no "normal" icon themes)

@z3ntu z3ntu added the bug label May 22, 2019
@nightsky30
Copy link
Author

nightsky30 commented May 27, 2019

At least the area is clickable and functioning. Is this something that should be fixed upstream say with the icon theme, Qt5, XFCE, or Xubuntu distro package? I'll gladly open an upstream issue :)

For reference I'm using the "Elementary Xfce darker" icon set...though maybe that is not what Qt uses??

Screenshot_2019-05-27_10-57-43

Qt5 settings (there does appear to be an issue with the Xubuntu setup):

Screenshot_2019-05-27_11-01-01

Screenshot_2019-05-27_11-03-55

I can't seem to override that stupid variable, and I'm not even sure if that would fix things...

@nightsky30
Copy link
Author

nightsky30 commented Jul 28, 2019

If anyone else finds their way here aggravated and wondering how to set the QT_QPA_PLATFORMTHEME variable to qt5ct or something else:

Xubuntu sets/overrides the QT_QPA_PLATFORMTHEME value in:

/etc/X11/Xsession.d/56xubuntu-session

I changed the following to remedy the error I was getting:

# QT5 apps to use GTK style
# export QT_QPA_PLATFORMTHEME=gtk2
export QT_QPA_PLATFORMTHEME=qt5ct

This did not fix the missing icon issue. Looking into raising an issue with https://github.com/shimmerproject/elementary-xfce

@ochosi
Copy link

ochosi commented Jul 28, 2019

So the icon name is just "configure"? If it's not shown in elementary-xfce it's probably also not in Gnome's icon theme, from where elementary-xfce inherits all missing icons. That may be a bigger problem than the icon missing in elementary-xfce.

Is that a standard qt icon name?
At least the freedesktop standard doesn't know that name: https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html

Alternatively you could also consider to switch to a standard icon name (especially if it's not a qt standard), e.g. "document-properties"

@z3ntu
Copy link
Owner

z3ntu commented Jul 29, 2019

Yes, in Breeze it's just configure:
image

How about preferences-system ? The icon packs listed at https://commons.wikimedia.org/wiki/Comparison_of_icon_sets have a fitting icon for the preferences.

preferences-other would also be an option but it seems that less icon packs support that one.

@ochosi
Copy link

ochosi commented Jul 29, 2019

preferences-system should work out fine!

@z3ntu z3ntu closed this as completed in 2c0496e Jul 29, 2019
z3ntu added a commit that referenced this issue Jul 29, 2019
The 'configure' icon is not a standard icon theme icon and probably only
available in the Breeze theme, so the preferences button was basically
invisible for many users.

Fix this by using the 'preferences-system' icon; and also increase the
size of the icon from 16x16 to 20x20 to make it more visible.

Fixes #50
@rios0rios0
Copy link

rios0rios0 commented Jan 28, 2020

Hello guys.
I have the same behavior.

OS: Ubuntu 18.04.03 LTS (I don't have any Icon Pack, and default appearance settings)
RazerGenie Version: 0.8.1
OpenRazer Daemon Version: 2.7.0

Thanks!

Screen

@z3ntu
Copy link
Owner

z3ntu commented Jan 30, 2020

@rios0rios0 The change is not included in RazerGenie 0.8.1. I have some changes that I want to include in the next release (a rewrite more or less) but I haven't got it finished yet, so the new release will still take a while, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants