Skip to content

Commit

Permalink
tools/bpf: Rename 'struct event' to avoid naming conflict
Browse files Browse the repository at this point in the history
On ppc64le, trying to build bpf seltests throws the below warning:
  In file included from runqslower.bpf.c:5:
  ./runqslower.h:7:8: error: redefinition of 'event'
  struct event {
	 ^
  /home/naveen/linux/tools/testing/selftests/bpf/tools/build/runqslower/vmlinux.h:156602:8:
  note: previous definition is here
  struct event {
	 ^

This happens since 'struct event' is defined in
drivers/net/ethernet/alteon/acenic.h . Rename the one in runqslower to a
more appropriate 'runq_event' to avoid the naming conflict.

Signed-off-by: Naveen N. Rao <[email protected]>
Acked-by: Daniel Borkmann <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/c13cb3767d26257ca4387b8296b632b433a58db6.1641468127.git.naveen.n.rao@linux.vnet.ibm.com
  • Loading branch information
rnav authored and mpe committed Jan 15, 2022
1 parent f9320c4 commit 88a7108
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/bpf/runqslower/runqslower.bpf.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ int handle__sched_switch(u64 *ctx)
*/
struct task_struct *prev = (struct task_struct *)ctx[1];
struct task_struct *next = (struct task_struct *)ctx[2];
struct event event = {};
struct runq_event event = {};
u64 *tsp, delta_us;
long state;
u32 pid;
Expand Down
2 changes: 1 addition & 1 deletion tools/bpf/runqslower/runqslower.c
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ static int bump_memlock_rlimit(void)

void handle_event(void *ctx, int cpu, void *data, __u32 data_sz)
{
const struct event *e = data;
const struct runq_event *e = data;
struct tm *tm;
char ts[32];
time_t t;
Expand Down
2 changes: 1 addition & 1 deletion tools/bpf/runqslower/runqslower.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#define TASK_COMM_LEN 16

struct event {
struct runq_event {
char task[TASK_COMM_LEN];
__u64 delta_us;
pid_t pid;
Expand Down

0 comments on commit 88a7108

Please sign in to comment.