Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] throws non-Error #328

Open
ericprud opened this issue May 23, 2016 · 4 comments
Open

[email protected] throws non-Error #328

ericprud opened this issue May 23, 2016 · 4 comments

Comments

@ericprud
Copy link

When I upgrade from [email protected] to [email protected] and pass an
unrecognized token to the generated parser, I get back an object which
is not an Error. 0.4.16 had:

    _parseError.prototype = new Error();

. 0.4.17 has something like (from memroy):

    _parseError.prototype = Error;

I don't know what the returned error is an instanceof, but it's not Error.

    _parseError.prototype = Error.prototye;

works for me (throws something which is an instanceof Error).

@summivox
Copy link

summivox commented Jun 8, 2016

LiveScript just updated dependencies and this also hit us.

@antonmedv
Copy link

Got same in monkberry.

emord added a commit to dimagi/js-xpath that referenced this issue Jun 23, 2016
@GerHobbelt
Copy link
Contributor

Wasn't this fixed with #325?

@enwin
Copy link

enwin commented Jan 11, 2017

It has been fixed with #325 but has not been pushed to npm. Version 0.4.17 still has the old version of /lib/jison.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants