Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement non-strict-alternative to valueOf factory method #14

Closed
wants to merge 1 commit into from

Conversation

fabianbuch
Copy link

in essence exposing VersionParser::parseVersionCore()

Reason:

Input version-strings might not always be valid semver style even if i want a valid semver in the end. 0.7.2 wasn't as strict in that regard, so it'd be nice to have a lenient parsing version that ignores everything apart from the parseable version-core (NormalVersion).

@zafarkhaja
Copy link
Owner

Thanks for the contribution, @fabianbuch.

I have a somewhat similar idea but with a little bit different approach to implementation. I want to keep the Version and the VersionParser as close to the SemVer specification as possible. At the same time, I know that there are plenty of widely adopted and used versioning systems that are not completely SemVer-compliant but could be made SemVer-compatible with little or no effort.

This could be achieved through extensions which I'm planning to introduce to the library as of version 1.0.0 (#12) and for that I'll have to rewrite the VersionParser (#9) to make it more flexible.

What you think?

P.S. I've implemented pretty much all the planned functionality so it won't take long to ship 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants