Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations #149

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Add annotations #149

merged 6 commits into from
Feb 5, 2024

Conversation

Dmitry-Erokhin
Copy link
Collaborator

@Dmitry-Erokhin Dmitry-Erokhin commented Jan 30, 2024

Description

  • Added support of annotation feature
  • Migrated work with Nakadi SLQ to PUT request to main endpoint (vs. attempt to identify change as auth or sql and call corresponding endpoint)
  • Minor refactoring
  • Bumped all versions

Types of Changes

  • New feature (non-breaking change which adds functionality)

Tasks

  • Add annotations to event type
  • Add annotations to sql
    • Refactor interactions for SQL to PUT query
    • Filtering only allowed changes
  • Remove nulls output in dump command
  • Refactor generation of payload for common approach in all places
  • Test main workflows
  • Adjust examples in docs

Review

  • Implementation
  • Documentation

@Dmitry-Erokhin Dmitry-Erokhin marked this pull request as ready for review January 31, 2024 09:12
@dlippok
Copy link
Collaborator

dlippok commented Feb 2, 2024

👍

@Dmitry-Erokhin Dmitry-Erokhin merged commit e4cfda1 into master Feb 5, 2024
4 checks passed
@Dmitry-Erokhin Dmitry-Erokhin deleted the add-annotations branch February 5, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants