ES-Operator doesn't separate system indices and ordinary users indices

[otrosien]

One-line summary

Exclude ES-Operator from managing system indices. This can be controlled per EDS. To avoid this being a breaking change, the default setting is opt-in.

Issue : #161

Description

Added an optional setting to the EDS (spec.excludeSystemIndices). If set to true, the ES-Operator will filter out indices starting with "." (indication of an internal Elasticsearch index) when calculating shard-per-node ratio and scaling index replica counts.

It will still check all shards even ones for system indices when draining to make sure we don't terminte a node with data on it.

Types of Changes

• New feature (non-breaking change which adds functionality)
• Configuration change

Tasks

Open question: we introducing a double-negation property, which I'm not a big fan of. What do others think of that?

Review

List of tasks the reviewer must do to review the PR

• Tests
• Documentation (TODO)

Deployment Notes

Regarding manifest versioning, this should be fine, we're extending the resource with an optional property.

[otrosien]

@s-vkropotko FYI

[s-vkropotko]

Hey!
I can suggest to rename it to avoid to be a double-negative property:
excludeSystemIndices=false -> manageSystemIndices=true/operateSystemIndices=true?
WDYT?

[otrosien]

Hey!
I can suggest to rename it to avoid to be a double-negative property:
excludeSystemIndices=false -> manageSystemIndices=true/operateSystemIndices=true?
WDYT?

I was thinking about it but then do we introduce a new default to not manageSystemIndices (as default non-specified value becomes false)?

Also, these system indices are a PITA also for a different reason: They break our "shards-to-node ratio" calculation even if we ignore them - you could easily get into a situation of non-ideal shard distribution (e.g. 2 production shards on one node, 2 system shards on the other node) if system indices get colocated with user indices - so in our cluster we always try to move them away onto a dedicated (or otherwise non-critical) EDS.

[mikkeloscar]

👍

[otrosien]

👍