Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Allow scale-down when at one-shard-per-node #452

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

otrosien
Copy link
Member

@otrosien otrosien commented Nov 7, 2024

One-line summary

Issue: Due to a wrong edge-case handling, when hitting a one-shard-per-node setup, the es-operator will not scale-down further.

Closes #398

Description

There have been reports of es-operator being stuck during scale-down. It happens in this situation:

  • At maximum scaling we have one-shard-per-node
  • There is a scaling hint "DOWN" that doesn't execute, as the edge-case of having less than one shard per node (which was meant to avoid over-scaling at scale-up) is triggered.

Changes

  • Instead of stopping the scaling, ensure that the scaling respects a minimum value of one-shard-per-node.
  • Fixes the e2e test which were failing due to duplicate env variable

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

@otrosien otrosien added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Nov 7, 2024
Copy link

invalid team ID

The team ID in your .zappr.yaml file does not appear to be valid. Please, fix
this before team ID checks will be added back into ComPR's specification check.

You can follow this guideline for help.

@otrosien otrosien force-pushed the bugfix-single-shard-per-node-scaledown branch from 1ef093a to e463c59 Compare November 7, 2024 11:57
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien otrosien marked this pull request as ready for review November 7, 2024 12:44
@otrosien
Copy link
Member Author

otrosien commented Nov 7, 2024

👍

@hooseins
Copy link

hooseins commented Nov 7, 2024

👍

@otrosien otrosien merged commit 8c5a323 into master Nov 7, 2024
9 checks passed
@otrosien otrosien deleted the bugfix-single-shard-per-node-scaledown branch November 7, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operator stuck in scale down loop
2 participants