Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Fix the docs for the RBAC examples, and add "get" permission on peering #50

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Apr 29, 2019

Issue : #12, #49

The docs were missing the cluster-vs-namespaced object separation.

And there were no "GET" permission on the peering object by its name. Now, it is added to address our incident (see #49 background).

These docs will be later affected by #36.

@nolar nolar added bug Something isn't working documentation Documentation improvements labels Apr 29, 2019
@nolar nolar requested a review from samurang87 as a code owner April 29, 2019 10:02
@zincr
Copy link

zincr bot commented Apr 29, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Apr 29, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar removed the request for review from samurang87 April 29, 2019 14:55
@nolar nolar merged commit a541c83 into zalando-incubator:master Apr 29, 2019
@nolar nolar deleted the 49-rbac-get-permission branch April 29, 2019 14:57
@nolar nolar added this to the 1.0 milestone Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants