Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define VPA as single app with components #3002

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Define VPA as single app with components #3002

merged 1 commit into from
Feb 20, 2020

Conversation

mikkeloscar
Copy link
Contributor

@mikkeloscar mikkeloscar commented Feb 19, 2020

We labelled the vpa "backwards" when we introduced it. This means we have 3 apps defined in our application registry, when we only need one.

Change all components to have application: vpa application: vertical-pod-autoscaler and a custom component label.

To roll this out in a "safe" way I added pre-apply delete for all components. For updater and recommender this is ok to happen all the time, for admission-controller I renamed it to have -new suffix which I will rename later with another PR once this is all rolled out.

@mikkeloscar mikkeloscar marked this pull request as ready for review February 19, 2020 16:38
@mikkeloscar mikkeloscar reopened this Feb 19, 2020
@hjacobs
Copy link
Contributor

hjacobs commented Feb 20, 2020

vertical-pod-autoscaler might be a better application ID --- more meaningful and less confusing (other colleagues should not have to guess when they see "vpa")

@mikkeloscar mikkeloscar force-pushed the unify-vpa-components branch 2 times, most recently from 68658ec to f816c86 Compare February 20, 2020 08:09
@mikkeloscar
Copy link
Contributor Author

@hjacobs good point. I have changed it.

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
@mikkeloscar
Copy link
Contributor Author

👍

1 similar comment
@hjacobs
Copy link
Contributor

hjacobs commented Feb 20, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants