Add a cluster-local file to the secrets #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Signed-off-by: Alexey Ermakov <[email protected]>
aermakov-zalando
force-pushed
the
add-dummy-file
branch
from
988808d
to
71ac64d
Compare
|
👍 |
1 similar comment
|
👍 |
This was referenced Feb 24, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our e2e clusters run with the same set of certificates, so the generated 'secrets' file is the same for all of them. However, they're encrypted with a per-run KMS key, so it's possible that an e2e will fail because its secrets are reencrypted with a key from a different run. Add a dummy file with the cluster's local ID to prevent this as a quick hack.