Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split skipper lightstep config over multiple lines #3026

Merged
merged 1 commit into from
Feb 26, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cluster/manifests/skipper/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,21 @@ spec:
{{ end }}
- "-oauth2-tokeninfo-url={{ .ConfigItems.tokeninfo_url }}"
- "-histogram-metric-buckets=.0001,.00025,.0005,.00075,.001,.0025,.005,.0075,.01,.025,.05,.075,.1,.2,.3,.4,.5,.75,1,2,3,4,5,7,10,15,20,30,60,120,300,600"
- "-opentracing=lightstep component-name=skipper-ingress token=$(LIGHTSTEP_TOKEN) collector=tracing.stups.zalan.do:8444 cmd-line=skipper-ingress max-buffered-spans={{ .ConfigItems.skipper_ingress_tracing_buffer }} tag=application=skipper-ingress tag=account={{ .Cluster.Alias }} tag=cluster={{ .Cluster.Alias }} tag=artifact=registry.opensource.zalan.do/pathfinder/skipper:v0.11.48 grpc-max-msg-size={{ .ConfigItems.skipper_ingress_lightstep_grpc_max_msg_size }} max-period={{ .ConfigItems.skipper_ingress_lightstep_max_period }} min-period={{ .ConfigItems.skipper_ingress_lightstep_min_period }} {{ .Cluster.ConfigItems.skipper_ingress_lightstep_log_events }}"
- >-
-opentracing=lightstep
component-name=skipper-ingress
token=$(LIGHTSTEP_TOKEN)
collector=tracing.stups.zalan.do:8444
cmd-line=skipper-ingress
max-buffered-spans={{ .ConfigItems.skipper_ingress_tracing_buffer }}
tag=application=skipper-ingress
tag=account={{ .Cluster.Alias }}
tag=cluster={{ .Cluster.Alias }}
tag=artifact=registry.opensource.zalan.do/pathfinder/skipper:v0.11.48
grpc-max-msg-size={{ .ConfigItems.skipper_ingress_lightstep_grpc_max_msg_size }}
max-period={{ .ConfigItems.skipper_ingress_lightstep_max_period }}
min-period={{ .ConfigItems.skipper_ingress_lightstep_min_period }}
{{ .Cluster.ConfigItems.skipper_ingress_lightstep_log_events }}
- "-opentracing-excluded-proxy-tags={{ .ConfigItems.skipper_ingress_opentracing_excluded_proxy_tags }}"
- "-expect-continue-timeout-backend={{ .ConfigItems.skipper_expect_continue_timeout_backend }}"
- "-keepalive-backend={{ .ConfigItems.skipper_keepalive_backend }}"
Expand Down