support compacted event types (#154) via spring beans #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are still missing, so I have no idea whether this works this way.
- change new files to JUnit 5 - replace @parameterized by subclasses
- README updates - rewritten the extractor logic - test for the spring injection - removed the registerCompactionKeyExtractor from the EventLogWriter
ePaul
added
auto-configuration
|
I plan to make two variant release candidate builds with both options, so I can try this out in an actual project where the need for this arose. (But I'm not sure whether I can get to this this week.) |
6 tasks
* README improvements * removal of unneeded empty lines * EventLogWriter.fireBusinessEvents now takes `Collection<?>` instead of `Collection<Object>`, same as the other plural fire methods. * rename variable to be more clear * add javadoc * extract some code out of a loop * add tests for transmission service
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another implementation of #154, where the user can define the compaction key extractors as spring beans, instead of using a register function on the event log writer (as was done in #158).
This seems to be a more spring-y way of doing this.
Doing this also gave the need/opportunity to rewrite the internal logic of finding the right extractor.
Opinions please: is this better or worse than the way in #158?(Most of the commits are the same as in #158, the last ones are the new ones.)
For the change log:
You now can fire events for a compacted event type, by adding a CompactionKeyExtractor spring bean.