Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ingress path ratelimit example #1832

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Adds ingress path ratelimit example #1832

merged 1 commit into from
Aug 30, 2021

Conversation

AlexanderYastrebov
Copy link
Member

Fixes #1831

Signed-off-by: Alexander Yastrebov [email protected]

@AlexanderYastrebov
Copy link
Member Author

The build apparently fails due to cespare/xxhash#54 on CI

GO111MODULE=on go build -buildmode=plugin -o _test_plugins/predicate_match_none.so _test_plugins/predicate_match_none.go
# github.com/cespare/xxhash/v2
asm: xxhash_amd64.s:120: when dynamic linking, R15 is clobbered by a global variable access and is used here: 00092 (/go/pkg/mod/github.com/cespare/xxhash/[email protected]/xxhash_amd64.s:120)	ADDQ	R15, AX
asm: assembly failed
Makefile:94: recipe for target '_test_plugins/predicate_match_none.so' failed
make: *** [_test_plugins/predicate_match_none.so] Error 2

I could not reproduce on local machine so far.

@AlexanderYastrebov
Copy link
Member Author

AlexanderYastrebov commented Aug 24, 2021 •
edited
Loading

#1834 fixes the build failure

@AlexanderYastrebov
Adds ingress path ratelimit example
36c640d 
Fixes #1831

Signed-off-by: Alexander Yastrebov <[email protected]>
@szuecs
Copy link
Member

szuecs commented Aug 30, 2021

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit 8983965 into master Aug 30, 2021
@AlexanderYastrebov AlexanderYastrebov deleted the path-ratelimit-docs branch August 30, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkeloscar mikkeloscar mikkeloscar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom route-level clusterClientRatelimit in Ingress
3 participants
@AlexanderYastrebov @szuecs @mikkeloscar