fix: terminate etcd process after running tests #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Hahn <[email protected]>
|
👍 |
1 similar comment
|
👍 |
|
Thanks a lot for merging! |
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 11, 2023
Use ./... instead of loop over packages. Originally loop over packages was added by #359 that introduced glide package manager. This manager fetches dependencies into vendor/ subdirectory (see https://glide.readthedocs.io/en/latest/getting-started/) and apparently loop over packages was nessesary back then. glide usage was removed by #764 The change now also runs testable examples. Also: * fixes cmd/eskip etcd shutdown similar to #2359 * fixes cmd/eskip test intruduced by #2202 * fixes lua example * removed bench target as it makes little sense * .coverprofile-all can not be simplified yet due to golang/go#45361 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 11, 2023
Use ./... instead of loop over packages. Originally loop over packages was added by #359 that introduced glide package manager. This manager fetches dependencies into vendor/ subdirectory (see https://glide.readthedocs.io/en/latest/getting-started/) and apparently loop over packages was nessesary back then. glide usage was removed by #764 The change now also runs testable examples. Also: * fixes cmd/eskip etcd shutdown similar to #2359 * fixes cmd/eskip test intruduced by #2202 * fixes lua example * removed bench target as it makes little sense * .coverprofile-all can not be simplified yet due to golang/go#45361 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 11, 2023
Use ./... instead of loop over packages. Originally loop over packages was added by #359 that introduced glide package manager. This manager fetches dependencies into vendor/ subdirectory (see https://glide.readthedocs.io/en/latest/getting-started/) and apparently loop over packages was necessary back then. glide usage was removed by #764 The change now also runs testable examples. Also: * fixes cmd/eskip etcd shutdown similar to #2359 * fixes cmd/eskip test intruduced by #2202 * fixes lua example * removed bench target as it makes little sense * .coverprofile-all can not be simplified yet due to golang/go#45361 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 11, 2023
Use ./... instead of loop over packages. Originally loop over packages was added by #359 that introduced glide package manager. This manager fetches dependencies into vendor/ subdirectory (see https://glide.readthedocs.io/en/latest/getting-started/) and apparently loop over packages was necessary back then. glide usage was removed by #764 The change now also runs testable examples. Also: * fixes cmd/eskip etcd shutdown similar to #2359 * fixes cmd/eskip test introduced by #2202 * fixes lua example * removed bench target as it makes little sense * .coverprofile-all can not be simplified yet due to golang/go#45361 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 11, 2023
Use ./... instead of loop over packages. Originally loop over packages was added by #359 that introduced glide package manager. This manager fetches dependencies into vendor/ subdirectory (see https://glide.readthedocs.io/en/latest/getting-started/) and apparently loop over packages was necessary back then. glide usage was removed by #764 The change now also runs testable examples. Also: * fixes cmd/eskip etcd shutdown similar to #2359 * fixes cmd/eskip test introduced by #2202 * fixes lua example * removed bench target as it makes little sense * .coverprofile-all can not be simplified yet due to golang/go#45361 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 11, 2023
Use ./... instead of loop over packages. Originally loop over packages was added by #359 that introduced glide package manager. This manager fetches dependencies into vendor/ subdirectory (see https://glide.readthedocs.io/en/latest/getting-started/) and apparently loop over packages was necessary back then. glide usage was removed by #764 The change now also runs testable examples. Also: * increases redis testcontainer ping and shutdown timeouts after observed CI failures * fixes cmd/eskip etcd shutdown similar to #2359 * fixes cmd/eskip test introduced by #2202 * fixes lua example * removed bench target as it makes little sense * .coverprofile-all can not be simplified yet due to golang/go#45361 Signed-off-by: Alexander Yastrebov <[email protected]>
MustafaSaber
pushed a commit
that referenced
this pull request
Jul 12, 2023
Use ./... instead of loop over packages. Originally loop over packages was added by #359 that introduced glide package manager. This manager fetches dependencies into vendor/ subdirectory (see https://glide.readthedocs.io/en/latest/getting-started/) and apparently loop over packages was necessary back then. glide usage was removed by #764 The change now also runs testable examples. Also: * increases redis testcontainer ping and shutdown timeouts after observed CI failures * fixes cmd/eskip etcd shutdown similar to #2359 * fixes cmd/eskip test introduced by #2202 * fixes lua example * removed bench target as it makes little sense * .coverprofile-all can not be simplified yet due to golang/go#45361 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the etcd tests are done, etcd is not terminated.
Subsequent tests may therefore fail because an etcd process is still running and a new process of etcd can't start.
For example, if tests are run locally.
Executing os.Exit() terminates the program immediately; the deferred
etcdtest.Stop()function is not executed [1].The provided patch would terminate the etcd process in the end.
[1]: https://pkg.go.dev/os#Exit