cli/README.md: add src after GOPATH #625 #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zally should be cloned in `$GOPATH/src`, and not to `$GOPATH`, as per golang/dep#911. Otherwise dep won't work: ``` $ cd $GOPATH/github.com/zalando/zally/cli/zally/ $ dep ensure root project import: $GOPATH/github.com/zalando/zally/cli/zally is not within any GOPATH/src ``` where as `$GOPATH/src/github.com/zalando/zally/cli/zally` does work with dep.
netme
approved these changes
Jan 9, 2018
| @@ -11,7 +11,7 @@ Just make sure that an issue describing the bug or feature does not already exis | |||
| ## Pull Requests | |||
| Follow these steps to contribute your work to Zally: | |||
|
|
|||
| 1. [Open an issue](https://github.com/zalando/zally/issues) describing the problem or proposed feature. Ask maitainers (in the issue thread) to assign the issue to you so we know who is working on what. | |||
| 1. [Open an issue](https://github.com/zalando/zally/issues) describing the problem or proposed feature. Ask maintainers (in the issue thread) to assign the issue to you so we know who is working on what. | |||
kingslef
force-pushed
the
fix/cli-readme-gopath
branch
from
07bff90
to
169ba7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
=========================================
Coverage 83.31% 83.31%
Complexity 816 816
=========================================
Files 151 151
Lines 2218 2218
Branches 308 308
=========================================
Hits 1848 1848
Misses 234 234
Partials 136 136Continue to review full report at Codecov.
|
|
👍 |
|
@maxim-tschumak , @mfellner could you please give another 👍 ? |
|
@kingslef thanks! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zally should be cloned in
$GOPATH/src, and not to$GOPATH, as pergolang/dep#911. Otherwise dep won't work:
where as
$GOPATH/src/github.com/zalando/zally/cli/zallydoes work with dep.Related to #625.