feat: use fhevm deployer private key for deployment #552
+362
−555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatZama
force-pushed
the
deploymentTasks
branch
from
c196002
to
69a2331
Compare
leventdem
reviewed
Oct 4, 2024
| export PRIVATE_KEY_KMS_SIGNER_1="bbaed91514fa4b7c86aa4f73becbabcf4bce0ae130240f0d6ac3f87e06812440" | ||
| export PRIVATE_KEY_KMS_SIGNER_2="1bfa3e2233b0103ad67954a728b246c528916791f7fab4894ff361e3937b47e1" | ||
| export PRIVATE_KEY_KMS_SIGNER_3="7a604eed8cf4a43277d192aa0c7894d368577a4021e52bf45420f256e34c7dd7" | ||
| export ADDRESS_KMS_SIGNER_0="0x0971C80fF03B428fD2094dd5354600ab103201C5" |
There was a problem hiding this comment.
Very useful to have the address instead of the private key, in real context we are adding Ethereum addresses!
leventdem
approved these changes
Oct 4, 2024
chore: cleanup README feat: add option to pass addresses for kms signers instead of private keys chore: typo and cleanup in sh script
jatZama
force-pushed
the
deploymentTasks
branch
from
69a2331
to
0943a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now instead of using the mnemonic+
signers[9]for the fhevm deployer, I am using a new env variablePRIVATE_KEY_FHEVM_DEPLOYER.I also updated the
launch-fhevm.sh.Also I added an optional argument
useAddressto be used in thetask:addSignerswhen adding the KMS signers after deployment of KMSVerifier, this will fetch addresses env variables from the.envinstead of private keys for the kms signers.I also did some cleaning, like renaming
computePredeployAddresstocomputeGatewayAddress, removed obsolete tasks, moved old obsolete contracts in legacy folder etc.