removed password from posmeta and login fb user directly #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, works for me, just tested. This one was one of the key issues on my list as well. |
zanematthew
pushed a commit
that referenced
this pull request
Jun 8, 2015
removed password from posmeta and login fb user directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Zane, I think is not a good idea to store plain password in the postmeta table. Anyone with access to the database could login that user.
I changed the code a bit, as the user logs with facebook we are able to retrieve user_id, then we can directly login the user without the need of the password.
Anyway try it yourself and let me know. This is how Wordpress Social Login auths the user and my tests seems to work fine.