-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of non root user, zap options and custom reports dir #49
Conversation
c362d6e
to
ac3c3bf
Compare
Thank you for the contribution, I'll test this over the weekend. |
@sshniro any news? |
This needs to be rebased to pick the latest changes, also, the commit history should be tidied up (better leave the dist generation in a last commit to make it easier to update). |
The changelog should be updated. |
ac3c3bf
to
abd5193
Compare
Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> Changed default Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> dist prepared Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> added zap options as a separate input so we can handle the double quotes around this param Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> added option to set reports directory Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> added new params to action.yml Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> doc improved Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> fixed styles Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> fixed styles Signed-off-by: Juan Matias Kungfoo de la Camara Beovide <[email protected]> dist rebuild
abd5193
to
bd836a5
Compare
@thc202 sorry for the late reply, the branch was rebased, conflicts solved and all commits merged into one. Please, let me know what else I can do. |
Hi @juanmatias , I was not able to run this previously. Unfortunately, I can test this on Friday only. I will test and update the results. Apart from it, the code LGTM! |
For info the root user is no longer used as per #77 |
Closing, for authentication and more customization it's better to use the Automation Framework and its action. |
I was trying to use image ictu/zap2docker-weekly with this action. This because I need to login into the site with user and pwd.
To accomplish this I changed these:
If no parameters added, the defaults are to use root user, to have an empty string as zap parameters and to user current dir as base for reports.
In the readme it is explained and I added a simple example on how to use the after-mentioned image creating and publishing a report as artifact.