Optional PR: Move optional params to object (WIP) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
force-pushed
the
artifactName-to-options-object
branch
4 times, most recently
from
78d624c
to
08932d3
Compare
tony
changed the title
artifactName to objectThis fixes multiple issues posting during subsequent run(s) when artifactName was specified. Signed-off-by: Tony Narlock <[email protected]>
By changing artifactName to be in an object before before releasing we avoid positional, unnamed arguments that can cause confusion when the signature is extended. The curly brackets are destructuring assignment. Signed-off-by: Tony Narlock <[email protected]>
Fixes the same issue of avoiding confusion with parameters are added to the signature. Signed-off-by: Tony Narlock <[email protected]>
tony
force-pushed
the
artifactName-to-options-object
branch
from
08932d3
to
904a39f
Compare
tony
changed the title
tony
force-pushed
the
artifactName-to-options-object
branch
from
f876682
to
904a39f
Compare
|
Closing this for now as time has passed. I like this change and heavily prefer objects over positional arguments for clarity avoiding refactors when options are added/deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the signature becoming unwieldy in the event future params are introduced. Improvement on top of #15
allowIssueWritingandartifactNameare subject to thisWhen sending object literals we can know the param being passed by name, and also use them with minimal bloat thanks to destructuring.
Includes #21