Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] authhelper: dynamically add/remove authentication and session mgmt methods #4609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

forgedhallpass
Copy link

…es through API

* related PR on ZAP: zaproxy/zaproxy#7857

Signed-off-by: forgedhallpass <[email protected]>
@thc202 thc202 changed the title Integration of custom Authentication and SessionManagement method types through API authhelper: dynamically add/remove authentication and session mgmt methods May 19, 2023
@thc202 thc202 changed the title authhelper: dynamically add/remove authentication and session mgmt methods [WIP] authhelper: dynamically add/remove authentication and session mgmt methods May 19, 2023
@forgedhallpass
Copy link
Author

@thc202 this is not WIP, because the work is done. I have tested it locally.

The builds are failing, because these changes are dependent on the PR referenced in the description, hence the initial title "integration" of those changes from ZAP into this repository.

@thc202
Copy link
Member

thc202 commented May 19, 2023

It's WIP, it depends on unreleased core changes.

@forgedhallpass
Copy link
Author

It's WIP, it depends on unreleased core changes.

I see, I thought you have some labels to mark PRs that have a dependency. What I meant is that the work is done from my part.

@psiinon
Copy link
Member

psiinon commented May 19, 2023

We cant merge any changes to zap-extensions that depend on unreleased zaproxy changes.
We can get around that using reflection and handling the possibility that someone will be using the current version of the core rather than the unreleased one.

@thc202
Copy link
Member

thc202 commented May 19, 2023

That would be safer, since core will start throwing an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants