chore: bump cibuildwheel version, use action

[henryiii]

Followup to #308. General recommendations:

• There should be a pyproject.toml. Then these cibuildwheel settings can be put there. You also need the lines here if you add one: https://scikit-hep.org/developer/packaging#pep-517518-support-high-priority - FYI, setup_requires is deprecated and produces a warning.
• Checkout and upload/download actions are using v1. You should use v2.
• You can set up a dependabot update following https://cibuildwheel.readthedocs.io/en/stable/faq/#automatic-updates
• This will also enable musllinux wheels, can be manually skipped if you don't want to ship for musl
• This will use manylinux2014 as default for all wheels - can be set lower if you need manylinux2010 still (ideally in TOML, so you can set <3.9 as 2010 and 3.10+ as 2014 using overrides). Looks like manylinux2010 is going away, though: Drop support for manylinux2010 images August 1st, 2022 pypa/manylinux#1281. Mostly 3.6 & 3.7 are affected. Dropping before that happens is one solution. ;)
• It doesn't look like you are building for M1, see https://cibuildwheel.readthedocs.io/en/stable/faq/#apple-silicon (scroll down a little for an example). There's also guides to build for emulated linux architectures.

I'd also recommend testing on 3.10. You could add 3.10 and drop 3.6, if you want to keep to 4 versions (or non-EOL) versions supported.

[jakirkham]

Thanks Henry! This is great 😄

Had a couple questions below 🙂

[jakirkham]

Really like this simplification 😄

[jakirkham]

Do we need to add pipx as a requirement somewhere? Or is that already installed?

[henryiii]

It's built into the default runners as a supported package manager. See https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md or any other platform under https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-software . It does not require setup-python (that could be moved below this line). (pipx is included in manylinux images, too, which is really handy when you want to run something like nox/tox on many Pythons ;) )

[jakirkham]

AFAICT cibuildwheel still supports Python 3.6, correct? Is there anyway for us to state here that we still support it? Just want to make sure if an update to cibuildwheel drops Python 3.6 from cibuildwheel that we catch it (admittedly maybe we should be looking to drop Python 3.6 anyways just want to make sure we do that explicitly as opposed to implicitly due to tooling changes).

[henryiii]

I think we plan to support 3.6 until manylinux drops it, which is mid next year, according to pypa/manylinux#1260 (Ubuntu 18.04 EOL). Most of the time I split jobs based on Python version, like https://github.com/scikit-hep/boost-histogram/blob/develop/.github/workflows/wheels.yml (and you can see the toml config at https://github.com/scikit-hep/boost-histogram/blob/develop/pyproject.toml) - that will end up with an empty matrix element if a version was missing. You could just add a check after this for a file containing cp36 in the wheelhouse, though.

cibuildwheel will pick up python_requires, by the way, ideally if you set it in your setup.cfg, but also if it's very simply set in setup.py. It uses this for skipping though, not really checking to see if it's missing anything.

[jakirkham]

Ok sounds like there isn't a good way to do this, but that's ok since Numcodecs will most likely drop Python 3.6 before cibuildwheel does.

[jakirkham]

Thanks again Henry! LGTM 😄

[jakirkham]

@joshmoore would you be able to review? 🙂

[joshmoore]

would you be able to review?

LGTM as well. We're currently at v0.10.0.a1. Happy to trigger an a2 to test the process. Then we should probably start considering a release with the Entrypoints PR.

[jakirkham]

We probably want to add Python 3.10 to CI after this just to see what happens. Not expecting any surprises. Then should be good to try an alpha I think

[joshmoore]

In that case, let me try it here.

[joshmoore]

All the new 3.10 builds passed. Just waiting on the slower wheels builds now.

[jakirkham]

Looks green. Sounds like we are happy here. So went ahead and merged. Hope that is ok 🙂

Thanks Henry and Josh! 😀

[joshmoore]

v0.10.0.a2 pushed pushed (Edit: pushed pushed pushed pushed)