Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply assorted ruff/refurb rules (FURB) #1873

Merged
merged 4 commits into from
May 17, 2024
Merged

Apply assorted ruff/refurb rules (FURB) #1873

merged 4 commits into from
May 17, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

Note: #1707 is the same applied to the main branch

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request May 13, 2024
Closed
6 tasks
@jhamman jhamman added the V3 Related to compatibility with V3 spec label May 16, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone May 16, 2024
@DimitriPapadopoulos
Apply ruff/refurb rule FURB118
3af435a 
FURB118 Use `operator....` instead of defining a lambda
@DimitriPapadopoulos
Apply ruff/refurb rule FURB171
7b92c37 
FURB171 Membership test against single-item container
@DimitriPapadopoulos
Apply ruff/refurb rule FURB113
880046b 
FURB113 Use `....extend(...)` instead of repeatedly calling `....append()`
@jhamman jhamman merged commit 88946d2 into zarr-developers:v3 May 17, 2024
18 checks passed
@jhamman
Copy link
Member

jhamman commented May 17, 2024

Thanks @DimitriPapadopoulos!

@DimitriPapadopoulos DimitriPapadopoulos deleted the FURB_v3 branch May 17, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
V3 Related to compatibility with V3 spec
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @jhamman