Adds index_location to sharding codec #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
reviewed
Nov 2, 2023
joshmoore
reviewed
Nov 14, 2023
copybara-service bot
pushed a commit
to google/tensorstore
that referenced
this pull request
Nov 20, 2023
This parameter is being added to the spec in: zarr-developers/zarr-specs#280 PiperOrigin-RevId: 584120745 Change-Id: I339ad73ce8c927dd4944178d4fb1a0515037023d
jbms
approved these changes
Dec 14, 2023
|
Do you think we should move forward with this @normanrz? |
|
Yes! I don't have merge rights so please go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #254 and proposed by @jbms, this PR adds the
index_locationconfiguration parameter to thesharding_indexedcodec.Allowing to place the shard index at the beginning of a file may be beneficial for writing shard on stores that support random writes.