Return $this instead of void #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phpfui
commented
Jan 16, 2023
phpfui
commented
- Added return $this; to all methods that did not return anything.
- Added return type of self for most methods. Only PHP 7.4 and higher support a return type of static, which is technically better.
- Removed return type of void on proxies and other class hierarchies that are not supported by PHP 7.1, but they still return $this.
Nitpick-CI
reviewed
Jan 16, 2023
| { | ||
| if ($isStartToken) { | ||
| $tokens->next(); | ||
| } elseif ($tokens->valid() && !$this->isEndToken($tokens->current())) { | ||
| foreach ($this->getSubConsumers() as $consumer) { | ||
| if ($consumer->isStartToken($tokens->current())) { | ||
| return; | ||
| return $this; |
There was a problem hiding this comment.
Line indented incorrectly; expected at least 20 spaces, found 18
Nitpick-CI
reviewed
Jan 17, 2023
src/Message.php
Outdated
| @@ -250,7 +255,10 @@ public function getAttachmentCount() : int | |||
| return \count($this->getAllAttachmentParts()); | |||
| } | |||
|
|
|||
| public function addAttachmentPart($resource, string $mimeType, ?string $filename = null, string $disposition = 'attachment', string $encoding = 'base64') : void | |||
| /** | |||
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
Nitpick-CI
reviewed
Jan 17, 2023
src/Message.php
Outdated
| @@ -250,7 +255,10 @@ public function getAttachmentCount() : int | |||
| return \count($this->getAllAttachmentParts()); | |||
| } | |||
|
|
|||
| public function addAttachmentPart($resource, string $mimeType, ?string $filename = null, string $disposition = 'attachment', string $encoding = 'base64') : void | |||
| /** | |||
| * @return static | |||
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
Nitpick-CI
reviewed
Jan 17, 2023
src/Message.php
Outdated
| public function addAttachmentPart($resource, string $mimeType, ?string $filename = null, string $disposition = 'attachment', string $encoding = 'base64') : void | ||
| /** | ||
| * @return static | ||
| */ |
There was a problem hiding this comment.
Spaces must be used to indent lines; tabs are not allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.