Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_address: Add support for ZIP 316, Revision 1 #1135

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Jan 25, 2024

Closes #1153.

@nuttycom nuttycom marked this pull request as draft January 25, 2024 23:50
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: Patch coverage is 56.60661% with 289 lines in your changes missing coverage. Please review.

Project coverage is 56.10%. Comparing base (8b49ca8) to head (d0431a2).

Files with missing lines Patch % Lines
zcash_keys/src/keys.rs 66.80% 82 Missing ⚠️
devtools/src/bin/inspect/keys/view.rs 0.00% 60 Missing ⚠️
components/zcash_address/src/kind/unified.rs 51.26% 58 Missing ⚠️
zcash_keys/src/address.rs 55.55% 44 Missing ⚠️
...mponents/zcash_address/src/kind/unified/address.rs 84.84% 10 Missing ⚠️
...ent_backend/src/data_api/wallet/input_selection.rs 14.28% 6 Missing ⚠️
..._sqlite/src/wallet/init/migrations/ufvk_support.rs 0.00% 6 Missing ⚠️
components/zcash_address/src/kind/unified/fvk.rs 77.77% 4 Missing ⚠️
components/zcash_address/src/kind/unified/ivk.rs 77.77% 4 Missing ⚠️
devtools/src/bin/inspect/address.rs 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
- Coverage   56.30%   56.10%   -0.21%     
==========================================
  Files         148      148              
  Lines       19062    19380     +318     
==========================================
+ Hits        10733    10873     +140     
- Misses       8329     8507     +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuttycom nuttycom added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2024
@nuttycom nuttycom marked this pull request as ready for review February 16, 2024 00:19
@nuttycom nuttycom marked this pull request as draft February 16, 2024 04:32
@nuttycom
Copy link
Contributor Author

Returning to draft status to update the parsing of the HRP for ZIP 316, Revision 1

@nuttycom nuttycom changed the title zcash_address: Add handling for Unified Metadata Items zcash_address: Add support for ZIP 316, Revision 1 Feb 16, 2024
@nuttycom nuttycom marked this pull request as ready for review February 16, 2024 22:04
zcash_keys/src/address.rs Outdated Show resolved Hide resolved
zcash_keys/src/address.rs Outdated Show resolved Hide resolved
zcash_keys/src/address.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed — see the "(blocking)" comments.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

@nuttycom nuttycom requested a review from daira April 1, 2024 22:14
@nuttycom nuttycom force-pushed the zcash_address/expiry branch 4 times, most recently from 5e60c27 to fa225d4 Compare April 23, 2024 22:31
@nuttycom nuttycom added the C-zip-impl Category: An implementation of a ZIP, or a request to do so label Jun 17, 2024
@nuttycom nuttycom requested a review from daira November 7, 2024 01:29
@nuttycom nuttycom force-pushed the zcash_address/expiry branch 3 times, most recently from 30f9e40 to 0ba0e2f Compare November 8, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-zip-impl Category: An implementation of a ZIP, or a request to do so S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zcash_address: Support Zip 316, Revision 1 (MUST-understand metadata)
3 participants