Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement BlockCache trait for FsBlockDb #1535

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement BlockCache trait for FsBlockDb #1535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6f9390b
zcash_client_backend: Switch from `async-trait` to RPIT for `BlockCache`
str4d Oct 26, 2024
36144f9
zcash_client_backend: Generalise `BlockSource::with_blocks` error
str4d Oct 29, 2024
95649dc
implement Sync for FsBlockDb and BlockDb so they can implement BlockC…
Oscar-Pepper Sep 10, 2024
d3bf952
replace block source with block cache in scan cached blocks
Oscar-Pepper Sep 10, 2024
69cf2d9
implement BlockCache for FsBlockDb
Oscar-Pepper Sep 11, 2024
22b7714
updated change logs
Oscar-Pepper Sep 11, 2024
163dbc7
implement BlockCache trait for MockBlockSource
Oscar-Pepper Sep 11, 2024
3d1c710
implement 'read' for BlockDb so it can call 'scan_cached_blocks'
Oscar-Pepper Sep 12, 2024
020438c
zcash_client_backend: Migrate test framework to be async
Oscar-Pepper Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ static_assertions = "1"
ambassador = "0.4"
assert_matches = "1.5"
criterion = "0.5"
futures = "0.3"
proptest = "1"
rand_chacha = "0.3"
rand_xorshift = "0.3"
Expand Down
10 changes: 10 additions & 0 deletions zcash_client_backend/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this library adheres to Rust's notion of
- `Progress`
- `WalletSummary::progress`
- `WalletMeta`
- `chain::truncate_block_cache` (behind the `sync` feature flag).
- `impl Default for wallet::input_selection::GreedyInputSelector`
- `zcash_client_backend::fees`
- `SplitPolicy`
Expand Down Expand Up @@ -80,6 +81,14 @@ and this library adheres to Rust's notion of
`ProposalDecodingError::FeeRuleNotSupported` has been added to replace it.
- `zcash_client_backend::data_api::fees::fixed` is now available only via the
use of the `non-standard-fees` feature flag.
- zcash_client_backend::data_api::chain:
- `BlockSource` added Send + Sync trait bounds
- `BlockSource::with_blocks` changed to async fn
- Changes to `BlockCache` trait:
- removed `sync` feature flag so it can be used in `scan_cached_blocks`
- all trait methods now return `zcash_client_backend::data_api::chain::error::Error`
so implementations may call `BlockSource::with_blocks` and propagate errors correctly.
- `scan_cached_blocks` now takes a block cache and a scan range for scanning.
- `zcash_client_backend::tor::http::cryptex`:
- The `Exchange` trait is no longer object-safe. Replace any existing uses of
`dyn Exchange` with `DynExchange`.
Expand All @@ -88,6 +97,7 @@ and this library adheres to Rust's notion of
- `zcash_client_backend::data_api`:
- `WalletSummary::scan_progress` and `WalletSummary::recovery_progress` have
been removed. Use `WalletSummary::progress` instead.
- `chain::BlockCache::truncate` (use `chain::truncate_block_cache` instead).
- `testing::input_selector` use explicit `InputSelector` constructors
directly instead.
- The deprecated `wallet::create_spend_to_address` and `wallet::spend`
Expand Down
3 changes: 1 addition & 2 deletions zcash_client_backend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ orchard = { workspace = true, optional = true }
sapling.workspace = true

# - Sync engine
async-trait = { version = "0.1", optional = true }
futures-util = { version = "0.3", optional = true }

# - Note commitment trees
Expand Down Expand Up @@ -173,8 +172,8 @@ orchard = ["dep:orchard", "dep:pasta_curves", "zcash_keys/orchard"]
## Exposes a wallet synchronization function that implements the necessary state machine.
sync = [
"lightwalletd-tonic",
"dep:async-trait",
"dep:futures-util",
"dep:trait-variant",
]

## Exposes a Tor client for hiding a wallet's IP address while performing certain wallet
Expand Down
Loading
Loading